Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Add SignOut overload + Use new auth api #6476

Merged
merged 2 commits into from
Jul 3, 2017
Merged

Add SignOut overload + Use new auth api #6476

merged 2 commits into from
Jul 3, 2017

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jun 30, 2017

rynowak
rynowak reviewed Jun 30, 2017
View reviewed changes
src/Microsoft.AspNetCore.Mvc.Core/SignOutResult.cs Outdated
/// Initializes a new instance of <see cref="SignOutResult"/> with the default sign out scheme.
/// </summary>
public SignOutResult()
: this(new string[0])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array.Empty<string>()

rynowak
rynowak reviewed Jun 30, 2017
View reviewed changes
src/Microsoft.AspNetCore.Mvc.Core/SignOutResult.cs
@@ -96,19 +99,21 @@ public SignOutResult(IList<string> authenticationSchemes, AuthenticationProperti
/* type: */ nameof(SignOutResult)));
}

if (AuthenticationSchemes.Count == 0)
{
throw new ArgumentException(Resources.MustSpecifyAtLeastOneAuthenticationScheme, nameof(AuthenticationSchemes));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this resource now?

@rynowak
Copy link
Member

rynowak commented Jun 30, 2017

Looks like the overloads on page/pagemodel/controller already support this. Dope.

@HaoK HaoK merged commit eeee3ef into dev Jul 3, 2017
@HaoK HaoK deleted the haok/auth branch August 7, 2017 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaoK @rynowak @dnfclas