This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Add UnprocessableEntityResult, UnprocessableEntityObjectResult and ControllerBase.UnprocessableEntity methods #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khellang
force-pushed
the
unprocessable-entity
branch
from
4713821 to
a8efc6d
Compare
khellang
force-pushed
the
unprocessable-entity
branch
from
a8efc6d to
c059527
Compare
pranavkm
reviewed
Sep 19, 2017
| /// <summary> | ||
| /// Creates a new <see cref="UnprocessableEntityObjectResult"/> instance. | ||
| /// </summary> | ||
| /// <param name="error">Contains the errors to be returned to the client.</param> |
| public void UnprocessableEntityObjectResult_ModelState_SetsStatusCodeAndValue() | ||
| { | ||
| // Arrange & Act | ||
| var result = new UnprocessableEntityObjectResult(new ModelStateDictionary()); |
There was a problem hiding this comment.
Maybe toss in an error in to the MSD so we know it's the type that's being serialized.
There was a problem hiding this comment.
There's no serialization in the test, and taht's fine. We don't need to overthink it
| /// </summary> | ||
| /// <returns>The created <see cref="UnprocessableEntityResult"/> for the response.</returns> | ||
| [NonAction] | ||
| public virtual UnprocessableEntityResult UnprocessableEntity() |
There was a problem hiding this comment.
public virtual UnprocessableEntityResult UnprocessableEntity() => new UnprocessableEntityResult() for 💯 points
There was a problem hiding this comment.
There are many other methods like this in the same class, it it worth the inconsistency?
There was a problem hiding this comment.
Let's leave this for #6864 😄
rynowak
reviewed
Sep 20, 2017
| /// <summary> | ||
| /// Creates an <see cref="UnprocessableEntityObjectResult"/> that produces a <see cref="StatusCodes.Status422UnprocessableEntity"/> response. | ||
| /// </summary> | ||
| /// <returns>The created <see cref="UnprocessableEntityObjectResult"/> for the response.</returns> |
pranavkm
approved these changes
Sep 21, 2017
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6795