Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Allow ApiControllerAttribute to be applied to assemblies #8403

Closed
wants to merge 1 commit into from
Closed

Allow ApiControllerAttribute to be applied to assemblies #8403

wants to merge 1 commit into from

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Sep 6, 2018

Fixes #7343

@pranavkm pranavkm requested a review from rynowak September 6, 2018 18:31
@pranavkm
Copy link
Contributor Author

pranavkm commented Sep 6, 2018

cc @khellang

@pranavkm pranavkm changed the title Allow ApiControlelrAttribute to be applied to assemblies Allow ApiControllerAttribute to be applied to assemblies Sep 6, 2018
@pranavkm pranavkm mentioned this pull request Sep 6, 2018
Merged
khellang
khellang approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@khellang khellang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kinda weird to apply an ApiController attribute on an assembly, but as long as it does the job, I don't really care 👌🏻

@pranavkm pranavkm closed this Sep 12, 2018
@pranavkm pranavkm deleted the prkrishn/api-controller-assembly branch September 12, 2018 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@khellang khellang khellang approved these changes

@rynowak rynowak rynowak approved these changes

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Assignees

@mkArtakMSFT mkArtakMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @khellang @rynowak @mkArtakMSFT