This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Moved SetTagHelperPropertyIRNode from renderer to writer #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
suggested changes
Apr 17, 2017
| @@ -101,6 +101,18 @@ public TagHelperWriterScope Push(TagHelperWriter writer) | |||
| return scope; | |||
| } | |||
|
|
|||
| public TagHelperRenderingContextScope Push(TagHelperRenderingContext context) | |||
There was a problem hiding this comment.
Value in exposing the scope type?
There was a problem hiding this comment.
Talked offline. Mind blown
| @@ -154,5 +166,27 @@ public void Dispose() | |||
| _context.TagHelperWriter = _writer; | |||
| } | |||
| } | |||
|
|
|||
| public struct TagHelperRenderingContextScope : IDisposable | |||
| csharp, | ||
| ignoreLineEndingDifferences: true); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should add indexer test for design time.
ajaybhargavb
force-pushed
the
ajbaaska/writer
branch
from
308eef5 to
9378055
Compare
|
🆙 📅 |
NTaylorMullen
approved these changes
Apr 17, 2017
ajaybhargavb
force-pushed
the
ajbaaska/writer
branch
4 times, most recently
from
41ea2f7 to
e1ad454
Compare
ajaybhargavb
force-pushed
the
ajbaaska/writer
branch
from
e1ad454 to
4e2cd0c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #1051
@NTaylorMullen @rynowak