This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Add indexer null-check for preallocated tag helper attributes #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
suggested changes
Jun 9, 2017
| __TestNamespace_InputTagHelper2.StringDictionaryProperty["grabber"] = (string)__tagHelperAttribute_4.Value; | ||
| __tagHelperExecutionContext.AddTagHelperAttribute(__tagHelperAttribute_4); | ||
| __TestNamespace_InputTagHelper1.StringDictionaryProperty["paprika"] = (string)__tagHelperAttribute_5.Value; | ||
| __tagHelperExecutionContext.AddTagHelperAttribute(__tagHelperAttribute_5); | ||
| __TestNamespace_InputTagHelper2.StringDictionaryProperty["paprika"] = (string)__tagHelperAttribute_5.Value; | ||
| __tagHelperExecutionContext.AddTagHelperAttribute(__tagHelperAttribute_5); | ||
| if (__TestNamespace_InputTagHelper1.StringDictionaryProperty == null) |
There was a problem hiding this comment.
This should still occur. You set the dictionary property below.
| @@ -0,0 +1,3 @@ | |||
| @addTagHelper *, TestAssembly | |||
|
|
|||
| <input type="text" prefix-hello="world" prefix-test="value" /> | |||
There was a problem hiding this comment.
We already have a preallocated test. Try adding this to that test (if it's not already duplicated).
NTaylorMullen
approved these changes
Jun 10, 2017
ajaybhargavb
force-pushed
the
ajbaaska/prealloc
branch
from
9d9cd5f to
6a1983b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #1057
@NTaylorMullen @rynowak