This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Added a check for property bag in tag helper descriptor comparer. #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cjqian, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -61,7 +62,8 @@ public virtual bool Equals(TagHelperDescriptor descriptorX, TagHelperDescriptor | |||
| descriptorX.AllowedChildren.OrderBy(child => child, StringComparer.OrdinalIgnoreCase), | |||
| descriptorY.AllowedChildren.OrderBy(child => child, StringComparer.OrdinalIgnoreCase), | |||
| StringComparer.OrdinalIgnoreCase))) && | |||
| descriptorX.TagStructure == descriptorY.TagStructure; | |||
| descriptorX.TagStructure == descriptorY.TagStructure && | |||
| descriptorX.PropertyBag.OrderBy(x => x.Key).SequenceEqual(descriptorY.PropertyBag.OrderBy(y => y.Key)); | |||
There was a problem hiding this comment.
- Do Enumerable.SequenceEqual to stay consistent with the above.
- Provide Comparer in both order bys
propertyX,propertyY
|
⌚ |
|
🆙 📅 |
| descriptorX.TagStructure == descriptorY.TagStructure; | ||
| descriptorX.TagStructure == descriptorY.TagStructure && | ||
| Enumerable.SequenceEqual( | ||
| descriptorX.PropertyBag.OrderBy(propertyX => propertyX.Key, StringComparer.OrdinalIgnoreCase), |
There was a problem hiding this comment.
The PropertyBag was constructed with a StringComparer.Ordinal why would this differ?
|
⌚ |
|
🆙 📅 |
| @@ -2,6 +2,7 @@ | |||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| using System; | |||
| using System.Collections; | |||
There was a problem hiding this comment.
Prob don't need this anymore
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnet/Mvc#1051