Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Revisit SchemeBuilder/AddScheme #1186

Closed
HaoK opened this issue Apr 24, 2017 · 3 comments
Closed

Revisit SchemeBuilder/AddScheme #1186

HaoK opened this issue Apr 24, 2017 · 3 comments
Assignees
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Apr 24, 2017

We probably need some more sugar around adding schemes today, namely:

authOptions.AddScheme<handlerType>(schemeName, displayName)

which today looks like:

authOptions.AddScheme(schemeName, o => {
   o.DisplayName = displayName;
   o.HandlerType = typeof<HandlerType>;
});

In fact, now that we don't have settings in the scheme anymore, we can probably just remove the scheme builder and only have this api.

Thoughts @Tratcher ?

@HaoK HaoK self-assigned this Apr 24, 2017
@HaoK HaoK added this to the 2.0.0-preview2 milestone Apr 24, 2017
@Tratcher
Copy link
Member

The current one is more future proof, but adding the sugar on top wouldn't hurt.

@HaoK
Copy link
Member Author

HaoK commented Apr 24, 2017

Yeah I guess knowing how auth usually goes, the ability to add stuff later will probably be nice :)

@HaoK
Copy link
Member Author

HaoK commented Jun 14, 2017

df5c6730f772775bfc9c14fbff050a1a56d9fef6

@HaoK HaoK closed this as completed Jun 14, 2017
@HaoK HaoK added 3 - Done and removed 1 - Ready labels Jun 14, 2017
@HaoK HaoK modified the milestones: 2.0.0, 2.1.0 Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants