DefaultForbid/SignOutSchemes + tests #870
Conversation
| /// <typeparam name="THandler">The <see cref="IAuthenticationHandler"/> responsible for the scheme.</typeparam> | ||
| /// <param name="name">The name of the scheme being added.</param> | ||
| /// <param name="displayName">The display name for the scheme.</param> | ||
| public void AddScheme<THandler>(string name, string displayName) where THandler : IAuthenticationHandler |
There was a problem hiding this comment.
Doesn't look like this will be used outside of tests. No?
There was a problem hiding this comment.
Sure it will, it's what end users could call to add handlers, its analogous to what hosting does: https://github.com/aspnet/IISIntegration/blob/dev/src/Microsoft.AspNetCore.Server.IISIntegration/IISMiddleware.cs#L53
except that's adding directly to the scheme provider rather than during startup/configure services.
Keep in mind, there's NOTHING on the builder, so the question I'm asking now is if we should nuke all of the Action<AuthenticationSchemeBuilder>... It was more useful when we had a bag on the builder that could be configured.
There was a problem hiding this comment.
Its just Name + DisplayName + Type, I guess its slightly more future proof with the action.
There was a problem hiding this comment.
But mainly I just wanted the sugar, we had a bug for this that got punted to 2.1, but since I'm here and adding tests :) aspnet/Security#1186
Part of the fix for: aspnet/Mvc#6392
Also added some tests + a sugar overload for AddScheme
@Tratcher @davidfowl