This repository was archived by the owner on Nov 22, 2018. It is now read-only.
Add RangeHelper #185
Merged
Add RangeHelper #185
+499
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbagga, |
Tratcher
suggested changes
Apr 7, 2017
| using Microsoft.Extensions.Primitives; | ||
| using Microsoft.Net.Http.Headers; | ||
|
|
||
| namespace Microsoft.AspNetCore.RangeHelper.Internal |
|
@Tratcher Updated |
jbagga
commented
Apr 7, 2017
| // The spec allows for multiple ranges but we choose not to support them because the client may request | ||
| // very strange ranges (e.g. each byte separately, overlapping ranges, etc.) that could negatively | ||
| // impact the server. Ignore the header and serve the response normally. | ||
| _logger.LogMultipleFileRanges(rawRangeHeader.ToString()); |
There was a problem hiding this comment.
The shared source does not have a logger. Should I add it? @Tratcher
There was a problem hiding this comment.
No, because then you'll have to add LogMultipleFileRanges (which you should now remove).
Tratcher
approved these changes
Apr 7, 2017
pranavkm
approved these changes
Apr 7, 2017
This was referenced Apr 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses aspnet/Mvc#3702
cc @Tratcher @pranavkm @Eilon