Merge pull request #463 from asteris-llc/fix/446-rpm-default

default to state 'present' for rpm module

resource/package/rpm/preparer.go

@@ -30,11 +30,15 @@ type Preparer struct {
 
 	// State of the package. Present means the package will be installed if
 	// missing; Absent means the package will be uninstalled if present.
-	State State `hcl:"state" valid_values:"present,absent" default:"present"`
+	State State `hcl:"state" valid_values:"present,absent"`
 }
 
 // Prepare a new packge
 func (p *Preparer) Prepare(render resource.Renderer) (resource.Task, error) {
+	if p.State == "" {
+		p.State = "present"
+	}
+
 	return &Package{
 		Name:   p.Name,
 		State:  p.State,

resource/package/rpm/preparer_test.go

@@ -17,9 +17,11 @@ package rpm_test
 import (
 	"testing"
 
+	"github.com/asteris-llc/converge/helpers/fakerenderer"
 	"github.com/asteris-llc/converge/resource"
 	"github.com/asteris-llc/converge/resource/package/rpm"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 // TestPreparerInterfaces ensures that the correct interfaces are implemented by
@@ -28,3 +30,33 @@ func TestPreparerInterfaces(t *testing.T) {
 	t.Parallel()
 	assert.Implements(t, (*resource.Resource)(nil), new(rpm.Preparer))
 }
+
+// TestPreparerCreatesPackage tests rpm.Package creation from the preparerer
+// ensuring that the state field is respected.
+func TestPreparerCreatesPackage(t *testing.T) {
+	t.Parallel()
+	t.Run("when-state-present", func(t *testing.T) {
+		p := &rpm.Preparer{Name: "test1", State: "present"}
+		task, err := p.Prepare(fakerenderer.New())
+		require.NoError(t, err)
+		asRPM, ok := task.(*rpm.Package)
+		require.True(t, ok)
+		assert.Equal(t, "present", string(asRPM.State))
+	})
+	t.Run("when-state-absent", func(t *testing.T) {
+		p := &rpm.Preparer{Name: "test1", State: "absent"}
+		task, err := p.Prepare(fakerenderer.New())
+		require.NoError(t, err)
+		asRPM, ok := task.(*rpm.Package)
+		require.True(t, ok)
+		assert.Equal(t, "absent", string(asRPM.State))
+	})
+	t.Run("when-state-missing", func(t *testing.T) {
+		p := &rpm.Preparer{Name: "test1"}
+		task, err := p.Prepare(fakerenderer.New())
+		require.NoError(t, err)
+		asRPM, ok := task.(*rpm.Package)
+		require.True(t, ok)
+		assert.Equal(t, "present", string(asRPM.State))
+	})
+}