Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid script syntax doesn't return a good error #113

Closed
BrianHicks opened this issue Jul 25, 2016 · 1 comment
Closed

invalid script syntax doesn't return a good error #113

BrianHicks opened this issue Jul 25, 2016 · 1 comment
Assignees
@rebeccaskinner
Labels
bug
Milestone
Strange Loop Demo...

Comments

@BrianHicks
Copy link
Contributor

BrianHicks commented Jul 25, 2016 •
edited
Loading

Should wrap in https://github.com/asteris-llc/converge/blob/feature/preparers/resource/shell/preparer.go#L62-L87, right now it just returns something like "exit status 2" for invalid syntax.

Something like errors.Wrap("invalid syntax", err) ought to do it.
@BrianHicks BrianHicks added the bug label Jul 25, 2016
@BrianHicks BrianHicks added this to the 0.2.0 milestone Jul 25, 2016
@rebeccaskinner rebeccaskinner self-assigned this Jul 27, 2016
@rebeccaskinner rebeccaskinner mentioned this issue Jul 27, 2016
Merged
@rebeccaskinner
Copy link
Contributor

PR: #121

rebeccaskinner pushed a commit that referenced this issue Jul 27, 2016
Return better error information for Shell module failures
04a40e7 
Fixes Issue #113

The `shell` module will now report (slightly) more
detailed error messages when failures occur during
a validation check.
@BrianHicks BrianHicks modified the milestones: 0.2.0, Strange Loop Demo (the real 0.2.0) Sep 8, 2016
BrianHicks pushed a commit that referenced this issue Dec 22, 2016
Return better error information for Shell module failures
8a118b8 
Fixes Issue #113

The `shell` module will now report (slightly) more
detailed error messages when failures occur during
a validation check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebeccaskinner rebeccaskinner

Labels
bug
Projects
None yet
Milestone
Strange Loop Demo (0.2.0)
Development

No branches or pull requests
2 participants
@rebeccaskinner @BrianHicks