JSONL output and interface refactoring #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accurately, split it out into two parts. In the base we don't need to know if a string is visible, so `Renderable` is now just a wrapper over `fmt.Stringer`. I've changed the implementation of `String` on `stringRenderable` to return the proper value if the string is hidden (an empty string.) Because of this, `Render` is gone as well. VisibleRenderable takes on the simplifications mentioned in #46. Namely, it removes `Hide` and `Unhide`. These weren't actually used outside the internal renderable implementation, so they didn't need to be part of the interface. There is some cleanup that had to take place to make this new split valid, but not too much. Mostly removing utility methods in favor of just calling `String` and/or wrapping renderables. In basically all cases, we can just unwrap the string at the call site instead of using a utility. This may lose a little fidelity, in which case the caller should definitely be requiring a `VisibleRenderable` instead of just `Renderable`. `SprintfVisible` was only needed in one case, it may yet be removed. Fixes #146
BrianHicks
pushed a commit
that referenced
this pull request
Dec 22, 2016
JSONL output and interface refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JSONL support to the prettyprinter. This was really just an excuse to get to know the pretty printer better for another feature, and in the process addresses #146 and #147.
@rebeccaskinner can you review this, especially 876c581? If you feel strongly that this is the wrong direction for that interface, we can remove the commit.