Migrate context for go1.7, refactor fetch/http.go #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.7 was released 2016-08-15, and one of the changes that was introduced was moving the context library from `golang.org/x/net/context` to just `context`. This commit subs in the new package location, but there was one file that needed extra work: `fetch/http.go`. This file used convenience functions in `x/net/context/ctxhttp`, which was not included in the new stdlib version of `context`. I replaced the call to `ctxhttp.Get` with more common calls, plus a call to `Request.WithContext`.
|
This fixes #161 |
|
LGTM |
|
What are these changes to vendor? |
|
What? Dang it, I thought I got rid of that stuff :/ |
BrianHicks
added a commit
that referenced
this pull request
Dec 22, 2016
Migrate context for go1.7, refactor fetch/http.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.7 was released 2016-08-15, and one of the changes that was
introduced was moving the context library from
golang.org/x/net/contextto justcontext.This commit subs in the new package location, but there was one file
that needed extra work:
fetch/http.go. This file used conveniencefunctions in
x/net/context/ctxhttp, which was not included in the newstdlib version of
context. I replaced the call toctxhttp.Getwithmore common calls, plus a call to
Request.WithContext.