Feature/shell refactor #172
Conversation
| after: | ||
| {{indent .After 2}}`) | ||
| {{indent .After 1}}`) |
There was a problem hiding this comment.
if this is tabs, could it just be {{indent .After}} now, which would just add another tab level?
There was a problem hiding this comment.
So, e.g. {{indent .Before 2}} would become {{indent (indent .Before)}}?
There was a problem hiding this comment.
yeah, but I don’t think we’d ever need it. A nicer syntax might be
{{.Before | indent | indent}}.
On 18 Aug 2016, at 14:39, Rebecca Skinner wrote:
after:
-{{indent .After 2}}) +{{indent .After 1}})So, e.g.
{{indent .Before 2}}would become{{indent (indent .Before)}}?You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/asteris-llc/converge/pull/172/files/0d7a4948092ae6ecdcb33d2fc58f42bc76821381#r75375010
There was a problem hiding this comment.
Okay that makes sense I'll go ahead and make that change.
| @@ -0,0 +1,8 @@ | |||
| param "filename" { | |||
There was a problem hiding this comment.
right now we have only valid samples in the root samples directory. Would it work to put this in samples/errors?
There was a problem hiding this comment.
I had it there originally, but it was causing the tests to fail because it's technically valid as far as converge validate is concerned, it only fails during actual execution time. We could maybe create a third directory for runtime error examples (or perhaps demonstrating runtime error output is better reserved for documentation and not so much a sample)
There was a problem hiding this comment.
I would think it would be good documentation… which we’re kind of
missing at the moment. So that’s an outstanding issue anyway!
On 18 Aug 2016, at 14:59, Rebecca Skinner wrote:
@@ -0,0 +1,8 @@
+param "filename" {I had it there originally, but it was causing the tests to fail
because it's technically valid as far asconverge validateis
concerned, it only fails during actual execution time. We could maybe
create a third directory for runtime error examples (or perhaps
demonstrating runtime error output is better reserved for
documentation and not so much a sample)You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/asteris-llc/converge/pull/172/files/0d7a4948092ae6ecdcb33d2fc58f42bc76821381#r75378150
|
LGTM! |
Refactor the Shell module to support more sophisticated response data in preparation for health checks.