Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic RPC #187

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Basic RPC #187

merged 1 commit into from
Aug 30, 2016

Conversation

BrianHicks
Copy link
Contributor

Opening this PR early to get feedback:

  1. Do the interfaces in the protobuf file look good?
  2. Do y'all think it's OK to inject the status function via a context, or should we make a wrapper method? (I'm now leaning toward the latter.)

@BrianHicks BrianHicks force-pushed the feature/rpc-#167 branch 2 times, most recently from 0e25c0e to 7a70576 Compare August 26, 2016 14:31
@BrianHicks BrianHicks changed the title [WIP, no merging!] Basic RPC Basic RPC Aug 26, 2016
@BrianHicks BrianHicks force-pushed the feature/rpc-#167 branch 4 times, most recently from f552d7f to e62698c Compare August 30, 2016 21:42
@BrianHicks
rpc: add
e62698c 
(squashes 51 commits, mainly to remove vendoring wackiness)
@BrianHicks BrianHicks merged commit f99151c into master Aug 30, 2016
@BrianHicks BrianHicks deleted the feature/rpc-#167 branch August 30, 2016 21:45
BrianHicks added a commit that referenced this pull request Dec 22, 2016
@BrianHicks
Merge pull request #187 from asteris-llc/feature/rpc-#167
5b7f4c2 
Basic RPC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BrianHicks