Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker.image resource redux #188

Merged
merged 2 commits into from
Aug 24, 2016
Merged

docker.image resource redux #188

merged 2 commits into from
Aug 24, 2016

Conversation

ryane
Copy link
Contributor

@ryane ryane commented Aug 23, 2016

This allows you to ensure a docker image exists on the host.

docker.image "busybox" {
  name = "busybox"
  tag = "latest"
  timeout = "60s"
}

Future Enhancements?

  • force pull
  • private registry support
  • configurable docker client
  • should we be able to ensure a docker image does NOT exist on the host?
  • blackbox test? would this be possible with wercker?
  • showing progress. docker pulls can take a while to run. do we have anything or have we thought about how to show progress of a long running resource in converge?

@rebeccaskinner
Copy link
Contributor

Can we rebase this on top of master?

There is a minor bug in image_test.go due to an API change with resource.TaskStatus, where Changes was renamed HasChanges for the health module, other than that it should be a clean rebase.

@ryane ryane force-pushed the docker.image-redux branch from bffe789 to d681d07 Compare August 24, 2016 15:28
@ryane
Copy link
Contributor Author

ryane commented Aug 24, 2016

done!

@arichardet
Copy link
Contributor

Could you please rebase so all your non-dependency changes are in one commit?

@ryane ryane force-pushed the docker.image-redux branch from d681d07 to 7b362b5 Compare August 24, 2016 20:18
@ryane
Copy link
Contributor Author

ryane commented Aug 24, 2016

done

@arichardet
Copy link
Contributor

LGTM!

@arichardet arichardet merged commit 310d178 into master Aug 24, 2016
@arichardet arichardet deleted the docker.image-redux branch August 24, 2016 21:24
BrianHicks pushed a commit that referenced this pull request Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants