Feature/health module #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| out = append(out, edge.Target().(string)) | ||
| out = append(out, g.Dependencies(edge.Target().(string))...) | ||
| } | ||
| for _, elem := range out { |
There was a problem hiding this comment.
this looks like it's doing three iterations over all the keys when it could be doing two. Why not:
- iterate over all DownEdges and recursive deps and add them to
deps - iterate over
depsto extract the keys?
|
A few fixups and the rebase you mentioned in Slack, but then LGTM 💯 |
rebeccaskinner
force-pushed
the
feature/health-module
branch
from
c4a8f2c to
60c579f
Compare
|
LGTM! |
added 17 commits
August 24, 2016 09:50
…issing license headers
rebeccaskinner
force-pushed
the
feature/health-module
branch
from
3fac44a to
44b4a6d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
healthcheckas a command with support for checking any module that implementshealthcheck.Checkincluding a default implementation for all modules that useresource.Status