Feature/value passing #220
Conversation
| @@ -39,6 +40,7 @@ func TestApplyNoOp(t *testing.T) { | |||
|
|
|||
| // test that applying applies the vertex | |||
| applied, err := apply.Apply(context.Background(), g) | |||
| fmt.Println("TestApplyNoOp: error: ", err) | |||
There was a problem hiding this comment.
there's a Printf method on the *testing.T that you can use here, and it won't output during verbose runs unless a test fails
There was a problem hiding this comment.
I saw that just now looking at Steve's code; handy but I decided that in this case the output is a bit extraneous so I went ahead and removed it.
rebeccaskinner
force-pushed
the
feature/value-passing
branch
from
70477b4 to
740e353
Compare
| @@ -1,6 +1,6 @@ | |||
| NAME = $(shell awk -F\" '/^const Name/ { print $$2 }' cmd/root.go) | |||
| VERSION = $(shell awk -F\" '/^const Version/ { print $$2 }' cmd/version.go) | |||
| TOLINT = $(shell find . -type f \( -not -ipath './vendor*' -not -ipath './docs_source*' -not -iname 'main.go' -iname '*.go' \) -exec dirname {} \; | sort -u) | |||
| TOLINT = $(shell find . -type f \( -not -ipath './vendor*' -not -ipath './rpc*' -not -ipath './docs_source*' -not -iname 'main.go' -iname '*.go' \) -exec dirname {} \; | sort -u) | |||
There was a problem hiding this comment.
rpc should actually be linted. ./rpc/pb/root.*.go are the ones that are probably causing issues
rebeccaskinner
force-pushed
the
feature/value-passing
branch
from
b863218 to
22908b1
Compare
rebeccaskinner
force-pushed
the
feature/value-passing
branch
from
e53a137 to
c3d6b9a
Compare
| "split": {}, | ||
| "lookup": {}, |
|
|
||
| // interpolation allows us to pass vars into scripts while still attempting to | ||
| // syntax check them. | ||
| Interpolations map[string]string `hcl:"interpolations"` |
There was a problem hiding this comment.
I'm looking at this code and I don't quite get what this does. Extra environment variables in K/V notation?
There was a problem hiding this comment.
Oh yeah sorry I forgot to remove that! It was something I added to get environment variables that weren't part of Env so I could get better insight into value passing. I'll remove it.
Add the ability to pass values between modules