Add user group support #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "github.com/asteris-llc/converge/resource" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
it's typical for an enum like this to define a custom string alias and then use that, to make it clear that non any 'ol string will do.
type State string
const Present State = "present"
// and then...
type Group struct {
State State
}There was a problem hiding this comment.
oh and they should probably be prefixed StatePresent etc
arichardet
force-pushed
the
feature/user-group
branch
from
ca857f5 to
c7b03c4
Compare
|
|
||
| const ( | ||
| GID_MIN = 1000 | ||
| GID_MAX = 32767 |
There was a problem hiding this comment.
could you document these constants, BTW? Just a comment will do. They're kind of random-looking otherwise
arichardet
force-pushed
the
feature/user-group
branch
from
c7b03c4 to
1dabf8a
Compare
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if gidVal >= math.MaxUint32 { |
There was a problem hiding this comment.
I don't think you need this validation. Setting the bit size parameter in the ParseUint call above should take care of it. https://play.golang.org/p/E1b_Asq0WQ
arichardet
force-pushed
the
feature/user-group
branch
from
1dabf8a to
dfd5a89
Compare
|
PR feedback addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for user group:
Includes sample/group.hcl
If no
"state"is included, the default is"present"