Make the logs quieter #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,14 +76,14 @@ real happens.`, | |||
|
|
|||
| verifyModules := viper.GetBool("verify-modules") | |||
| if !verifyModules { | |||
| clog.Warn("skipping module verfiction") | |||
| clog.Warn("skipping module verfication") | |||
There was a problem hiding this comment.
did you mean: "verification"?
| @@ -53,12 +53,12 @@ not display healthy checks.`, | |||
|
|
|||
| verifyModules := viper.GetBool("verify-modules") | |||
| if !verifyModules { | |||
| log.WithField("component", "client").Warn("skipping module verfiction") | |||
| log.WithField("component", "client").Warn("skipping module verfiaction") | |||
| @@ -106,7 +106,7 @@ func (e *executor) Plan(in *pb.LoadRequest, stream pb.Executor_PlanServer) error | |||
| logger = logger.WithField("function", "executor.Plan") | |||
|
|
|||
| if err := e.auth.authorize(ctx); err != nil { | |||
| logger.WithError(err).Info("authorization failed") | |||
| logger.WithError(err).Warning("authorization failed") | |||
There was a problem hiding this comment.
Is an authorization failure a Warning or an Error?
There was a problem hiding this comment.
On the server, it's a warning since a user failing authentication should be raised for audit purposes but it's a normal occurrence. It's (still) an error on the client side.
There was a problem hiding this comment.
Ah, that makes sense.
|
Made the spelling fixes, thanks for the catch @rebeccaskinner. I'll rebase after your next review :) |
BrianHicks
force-pushed
the
feature/compact-logging
branch
from
5a025e5 to
d66cfa1
Compare
|
The lint errors here are due to sample output, which we maybe shouldn't change. They're in code blocks anyway, so I'm not sure what it's complaining about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248