Fix/239 #288
Merged
Fix/239 #288
+36
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryane
reviewed
Sep 21, 2016
|
|
||
| return g.Transform(ctx, func(id string, out *graph.Graph) error { | ||
| r, e := g.Transform(ctx, func(id string, out *graph.Graph) error { |
There was a problem hiding this comment.
I know it's been brought up before that single-letter variable names can make things hard to read. not sure it's a problem here since you are just returning them (don't even really need them).
| @@ -33,9 +35,9 @@ type dependencyGenerator func(node *parse.Node) ([]string, error) | |||
| // the graph and creates edges to fit them | |||
| func ResolveDependencies(ctx context.Context, g *graph.Graph) (*graph.Graph, error) { | |||
| logger := logging.GetLogger(ctx).WithField("function", "ResolveDependencies") | |||
| logger.Debug("resolving dependencies") | |||
| logger.Info("resolving dependencies") | |||
There was a problem hiding this comment.
should this actually be an Info log instead of Debug?
There was a problem hiding this comment.
Yeah, looks like this changed back from the PR where I turned down the levels
BrianHicks
suggested changes
Sep 21, 2016
rebeccaskinner
force-pushed
the
fix/239
branch
2 times, most recently
from
9b25e49 to
664ce24
Compare
BrianHicks
approved these changes
Sep 21, 2016
added 7 commits
September 21, 2016 13:12
…traneous newlines
rebeccaskinner
force-pushed
the
fix/239
branch
from
5f77c51 to
5592068
Compare
BrianHicks
pushed a commit
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix calls to
lookupfailing when the nodes are inside of a module.