Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perform healthchecks over RPC #289

Merged
merged 2 commits into from
Sep 21, 2016
Merged

perform healthchecks over RPC #289

merged 2 commits into from
Sep 21, 2016

Conversation

rebeccaskinner
Copy link
Contributor

perform healthchecks over RPC

@rebeccaskinner
Copy link
Contributor Author

fixes #199

Copy link
Contributor

@BrianHicks BrianHicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an API conflict

// Healthcheck a module given by the location
rpc HealthCheck (LoadRequest) returns (stream StatusResponse) {
option (google.api.http) = {
post: "/api/v1/machine/plan"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts with plan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, copy-pasta error; fixed.

@BrianHicks BrianHicks merged commit 6a82853 into master Sep 21, 2016
@BrianHicks BrianHicks deleted the fix/199-rpc-health-checks branch September 21, 2016 18:11
BrianHicks added a commit that referenced this pull request Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants