Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle preparer fields where zero is valid #344

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Handle preparer fields where zero is valid #344

merged 1 commit into from
Oct 4, 2016

Conversation

arichardet
Copy link
Contributor

@arichardet arichardet commented Oct 3, 2016 •
edited
Loading

Uses #339 to handle module parameters in which zero is a valid value.
Updated the following modules:

  • file.mode
  • user.group
  • user.user

sehqlr
sehqlr approved these changes Oct 4, 2016
View reviewed changes
Copy link
Contributor

@sehqlr sehqlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good, and the new comments are nice. Approved

@sehqlr sehqlr merged commit 68dae91 into master Oct 4, 2016
@sehqlr sehqlr deleted the fix/valid-params branch October 4, 2016 15:04
BrianHicks pushed a commit that referenced this pull request Dec 22, 2016
@sehqlr
Merge pull request #344 from asteris-llc/fix/valid-params
f7ed36d 
Handle preparer fields where zero is valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehqlr sehqlr sehqlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arichardet @sehqlr