update docs with conditional changes #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaskinner
force-pushed
the
fix/conditional-docs
branch
from
2baf93b to
44d2463
Compare
arichardet
requested changes
Nov 14, 2016
| (case insensitive) will cause the *branch* to remain unevaluated. Any other | ||
| value is an error. | ||
| A predicate is a special kind of go text template. It's evaluated in two | ||
| passes. In the first pass `lookups` and `params` are rendered as they would be |
There was a problem hiding this comment.
Please add a comma, and the "s" making lookup and param plural should be outside quotes:
"In the first pass, lookups and params..."
| value is an error. | ||
| A predicate is a special kind of go text template. It's evaluated in two | ||
| passes. In the first pass `lookups` and `params` are rendered as they would be | ||
| for any other converge string. In the second pass the rendered string is |
There was a problem hiding this comment.
Add a comma after "In the second pass"
arichardet
approved these changes
Nov 14, 2016
BrianHicks
pushed a commit
that referenced
this pull request
Dec 22, 2016
update docs with conditional changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.