Use a single port #534
Merged
Use a single port #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHicks
force-pushed
the
feature/single-port
branch
2 times, most recently
from
91ade1e to
73df914
Compare
It doesn't have to be a root certificate here, just a regular ol' CA. Intermediate is just fine.
BrianHicks
force-pushed
the
feature/single-port
branch
from
73df914 to
dec3d87
Compare
|
Please address the codeclimate issue, otherwise LGTM. |
|
I don't think there's really anything to be done about that TODO. It's left in place as a hint if it ever breaks as part of an upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of any ports but 4774 (server) and 47740 (local server). It maintains SSL and adds a test to ensure that we don't fall back to weaker SSL.
Fixes #286