Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit-tests #575

Closed
wants to merge 1 commit into from
Closed

Fix unit-tests #575

wants to merge 1 commit into from

Conversation

JorisCos
Copy link
Collaborator

@JorisCos JorisCos commented Dec 6, 2021

This fixes unit tests.
The problem was coming from PL version which is 1.5.4 now

@jonashaag
Copy link
Collaborator

Does this break older PL versions though? We have >=1.01 in the requirements.

@mpariente
Copy link
Collaborator

Thanks for fixing the tests !

@mpariente
Copy link
Collaborator

It probably does break previous versions.
So let's fix the PL version under the backward incompatible change, make a release, and then we'll upgrade PL and drop previous versions in a new release, does this sound ok?

@jonashaag
Copy link
Collaborator

Or we could add a manual check to that particular module only. Probably using this code https://github.com/PyTorchLightning/pytorch-lightning/blob/f63222d9663e6af06738c64744522acf7cb20221/pytorch_lightning/utilities/imports.py#L46

@mpariente
Copy link
Collaborator

Just for reference, the deprecation cycle started here in 1.3 and was merged here for 1.5.

I haven't been following PL too much, my bad

@mpariente
Copy link
Collaborator

Or we could add a manual check to that particular module only. Probably using this code https://github.com/PyTorchLightning/pytorch-lightning/blob/f63222d9663e6af06738c64744522acf7cb20221/pytorch_lightning/utilities/imports.py#L46

Yes, that's also ok. For now, I'll just fix PL's version.

@mpariente mpariente closed this Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants