Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Commit

Permalink
Remove asdl (#21)
Browse files Browse the repository at this point in the history
This removes the ASDL code generation in favor of handwriting the AST. 

The motivations for moving away from the ASDL are:

* CPython compatibility is no longer a goal
* The ASDL grammar isn't as expressive as we would like
* The codegen scripts have a high complexity which makes extensions time
consuming
* We don't make heavy use of code generation (compared to e.g.
RustPython that generates Pyo3 bindings, a fold implementation etc).

We may want to revisit a grammar based code generation in the future,
e.g. by using [ungrammar](https://github.com/rust-analyzer/ungrammar)
  • Loading branch information
konstin authored Jul 5, 2023
1 parent 0f2e295 commit 2d1f69c
Show file tree
Hide file tree
Showing 12 changed files with 3,641 additions and 5,003 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,3 @@ jobs:
'core/**/*.rs'
'literal/**/*.rs'
'parser/**/*.rs'
'ast/asdl_rs.py'
147 changes: 0 additions & 147 deletions ast/Python.asdl

This file was deleted.

Loading

0 comments on commit 2d1f69c

Please sign in to comment.