This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Remove fold, unparse, and location features
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jun 19, 2023
| @@ -12,7 +12,6 @@ include = ["LICENSE", "Cargo.toml", "src/**/*.rs"] | |||
| resolver = "2" | |||
| members = [ | |||
| "ast", "core", "format", "literal", "parser", | |||
| "ast-pyo3", | |||
There was a problem hiding this comment.
This relies on fold, but it's also something I don't feel the need to maintain.
charliermarsh
force-pushed
the
charlie/fold
branch
from
075d5c6 to
9fdaab3
Compare
MichaReiser
approved these changes
Jun 19, 2023
ast/src/lib.rs
Outdated
| @@ -30,14 +23,7 @@ mod visitor { | |||
| #[cfg(feature = "location")] | |||
| pub mod located; | |||
| #[cfg(feature = "location")] | |||
There was a problem hiding this comment.
We also don't use the location feature ;)
charliermarsh
changed the title
fold and unparse featuresfold, unparse, and location features
charliermarsh
force-pushed
the
charlie/fold
branch
3 times, most recently
from
2b28fab to
4c88e59
Compare
charliermarsh
force-pushed
the
charlie/fold
branch
from
4c88e59 to
344a2c3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't make use of these features, and as we look to make changes to the AST, I'm not sure that it's worth investing the time in keeping them up-to-date. This was specifically motivated by our desire to add ranges to identifiers.
Test Plan
Ran the
ruffsuite locally against this branch.