Fix freethreaded include on Windows #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/freethreaded-windows
branch
from
2188839 to
94e5fab
Compare
charliermarsh
approved these changes
Oct 15, 2024
|
@charliermarsh checked the builds on his Windows machine, thanks! |
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Oct 16, 2024
See upstream fix at astral-sh/python-build-standalone#368 Co-authored-by: zanieb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all the changes of #326, I lost track of the critical change to actually enable free-threading on Windows — this was the only distribution I didn't verify manually since I don't have a Windows machine.
See python/cpython#112984 for details on Windows changes upstream.
Adds a post-build runtime check for this flag when relevant in CI to avoid future regressions d440dc3