Show ruff version on test start #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zanie/show-version
branch
from
661c08f to
326f487
Compare
zanieb
commented
Oct 21, 2023
Comment on lines
+34
to
+40
| # Display the long version if the executable supports it | ||
| try: | ||
| output = subprocess.check_output([executable.path, "version"]).decode().strip() | ||
| except subprocess.CalledProcessError: | ||
| output = ( | ||
| subprocess.check_output([executable.path, "--version"]).decode().strip() | ||
| ) |
There was a problem hiding this comment.
We use this instead of simply executable.version so we can get richer information when available.
konstin
approved these changes
Oct 23, 2023
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Oct 23, 2023
Adds a CI job which runs `ruff-lsp` tests against the current Ruff build. Avoids rebuilding Ruff at the cost of running _after_ the cargo tests have finished. Might be worth the rebuild to get earlier feedback but I don't expect it to fail often? xref astral-sh/ruff-lsp#286 ## Test plan Verified use of the development version by inspecting version output in CI; supported by astral-sh/ruff-lsp#289 and #8034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the long ruff version if supported by the binary.
Useful for testing e.g. #286 and astral-sh/ruff#8016