Respect typing_extensions imports of Annotated for B006.

typing_extensions.Annotated should be treated the same way as typing.Annotated. Signed-off-by: Zixuan James Li <[email protected]>
astral-sh · Aug 5, 2023 · effc23b · effc23b
1 parent 1ac2699
commit effc23b
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 1 deletion.
diff --git a/crates/ruff/resources/test/fixtures/flake8_bugbear/B006_B008.py b/crates/ruff/resources/test/fixtures/flake8_bugbear/B006_B008.py
@@ -256,3 +256,20 @@ def mutable_annotations(
     c: Annotated[Union[Set[str], abc.Sized], "annotation"] = set(),
 ):
     pass
+
+from typing_extensions import Annotated as Annotated_te
+
+def immutable_annotations(
+    a: Sequence[int] | None = [],
+    b: Optional[abc.Mapping[int, int]] = {},
+    c: Annotated_te[Union[abc.Set[str], abc.Sized], "annotation"] = set(),
+):
+    pass
+
+
+def mutable_annotations(
+    a: list[int] | None = [],
+    b: Optional[Dict[int, int]] = {},
+    c: Annotated_te[Union[Set[str], abc.Sized], "annotation"] = set(),
+):
+    pass
diff --git a/...rules/flake8_bugbear/snapshots/ruff__rules__flake8_bugbear__tests__B006_B006_B008.py.snap b/...rules/flake8_bugbear/snapshots/ruff__rules__flake8_bugbear__tests__B006_B006_B008.py.snap
@@ -1,5 +1,6 @@
 ---
 source: crates/ruff/src/rules/flake8_bugbear/mod.rs
+assertion_line: 59
 ---
 B006_B008.py:63:25: B006 Do not use mutable data structures for argument defaults
    |
@@ -110,4 +111,33 @@ B006_B008.py:256:62: B006 Do not use mutable data structures for argument defaul
 258 |     pass
     |
 
+B006_B008.py:271:27: B006 Do not use mutable data structures for argument defaults
+    |
+270 | def mutable_annotations(
+271 |     a: list[int] | None = [],
+    |                           ^^ B006
+272 |     b: Optional[Dict[int, int]] = {},
+273 |     c: Annotated_te[Union[Set[str], abc.Sized], "annotation"] = set(),
+    |
+
+B006_B008.py:272:35: B006 Do not use mutable data structures for argument defaults
+    |
+270 | def mutable_annotations(
+271 |     a: list[int] | None = [],
+272 |     b: Optional[Dict[int, int]] = {},
+    |                                   ^^ B006
+273 |     c: Annotated_te[Union[Set[str], abc.Sized], "annotation"] = set(),
+274 | ):
+    |
+
+B006_B008.py:273:65: B006 Do not use mutable data structures for argument defaults
+    |
+271 |     a: list[int] | None = [],
+272 |     b: Optional[Dict[int, int]] = {},
+273 |     c: Annotated_te[Union[Set[str], abc.Sized], "annotation"] = set(),
+    |                                                                 ^^^^^ B006
+274 | ):
+275 |     pass
+    |
+
 
diff --git a/crates/ruff_python_semantic/src/analyze/typing.rs b/crates/ruff_python_semantic/src/analyze/typing.rs
@@ -207,7 +207,7 @@ pub fn is_immutable_annotation(expr: &Expr, semantic: &SemanticModel) -> bool {
                     }
                 } else if matches!(call_path.as_slice(), ["typing", "Optional"]) {
                     is_immutable_annotation(slice, semantic)
-                } else if matches!(call_path.as_slice(), ["typing", "Annotated"]) {
+                } else if is_pep_593_generic_type(call_path.as_slice()) {
                     if let Expr::Tuple(ast::ExprTuple { elts, .. }) = slice.as_ref() {
                         elts.first()
                             .is_some_and(|elt| is_immutable_annotation(elt, semantic))