use kebab-case

astral-sh · Feb 26, 2025 · f854172 · f854172
1 parent e82b83a
commit f854172
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 8 deletions.
diff --git a/crates/ruff_python_parser/resources/inline/err/match_before_py310.py b/crates/ruff_python_parser/resources/inline/err/match_before_py310.py
@@ -1,4 +1,4 @@
-# parse_options: { "target_version": "3.9" }
+# parse_options: { "target-version": "3.9" }
 match 2:
     case 1:
         pass
diff --git a/crates/ruff_python_parser/resources/inline/ok/match_after_py310.py b/crates/ruff_python_parser/resources/inline/ok/match_after_py310.py
@@ -1,4 +1,4 @@
-# parse_options: { "target_version": "3.10" }
+# parse_options: { "target-version": "3.10" }
 match 2:
     case 1:
         pass
diff --git a/crates/ruff_python_parser/src/lib.rs b/crates/ruff_python_parser/src/lib.rs
@@ -664,7 +664,7 @@ impl FusedIterator for TokenIterWithContext<'_> {}
 #[cfg_attr(
     feature = "serde",
     derive(serde::Deserialize),
-    serde(rename_all = "lowercase")
+    serde(rename_all = "kebab-case")
 )]
 pub enum Mode {
     /// The code consists of a sequence of statements.

diff --git a/crates/ruff_python_parser/src/parser/options.rs b/crates/ruff_python_parser/src/parser/options.rs
@@ -21,7 +21,11 @@ use crate::{AsMode, Mode};
 /// let options = ParseOptions::from(PySourceType::Python);
 /// ```
 #[derive(Clone, Debug)]
-#[cfg_attr(feature = "serde", derive(serde::Deserialize))]
+#[cfg_attr(
+    feature = "serde",
+    derive(serde::Deserialize),
+    serde(rename_all = "kebab-case")
+)]
 pub struct ParseOptions {
     /// Specify the mode in which the code will be parsed.
     #[cfg_attr(feature = "serde", serde(default = "default_mode"))]

diff --git a/crates/ruff_python_parser/src/parser/statement.rs b/crates/ruff_python_parser/src/parser/statement.rs
@@ -2266,13 +2266,13 @@ impl<'src> Parser<'src> {
         let cases = self.parse_match_body();
 
         // test_err match_before_py310
-        // # parse_options: { "target_version": "3.9" }
+        // # parse_options: { "target-version": "3.9" }
         // match 2:
         //     case 1:
         //         pass
 
         // test_ok match_after_py310
-        // # parse_options: { "target_version": "3.10" }
+        // # parse_options: { "target-version": "3.10" }
         // match 2:
         //     case 1:
         //         pass

diff --git a/crates/ruff_python_parser/tests/fixtures.rs b/crates/ruff_python_parser/tests/fixtures.rs
@@ -166,7 +166,7 @@ fn test_invalid_syntax(input_path: &Path) {
 /// For example,
 ///
 /// ```python
-/// # parse_options: { "target_version": "3.10" }
+/// # parse_options: { "target-version": "3.10" }
 /// def f(): ...
 fn extract_options(source: &str) -> Option<ParseOptions> {
     // extract options from pragma on the first line

diff --git a/crates/ruff_python_parser/tests/snapshots/invalid_syntax@match_before_py310.py.snap b/crates/ruff_python_parser/tests/snapshots/invalid_syntax@match_before_py310.py.snap
@@ -55,7 +55,7 @@ Module(
 ## Unsupported Syntax Errors
 
   |
-1 | # parse_options: { "target_version": "3.9" }
+1 | # parse_options: { "target-version": "3.9" }
 2 | match 2:
   | ^^^^^ Syntax Error: Cannot use `match` statement on Python 3.9 (syntax was added in Python 3.10)
 3 |     case 1: