-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.7.3
introduces false positives for invalid # noqa
directives with RUF100
#14228
Comments
Yeah definitely, sorry about that. |
(You can probably work around it for now by adding a |
Is adding a |
I tend to do it because it disambiguates the content from the pragma (and it's easier for us to parse without any ambiguity). It's also nice if you have multiple pragmas on the same line, like |
Thanks so much for the rapid fix! You're awesome 🎉 |
I'm working on upgrading our codebase to use
ruff=0.7.3
, but there are someRUF100
changes that start flaggingsome comments as being "Unused
noqa
directive"s.I'm not sure if this is intentional (perhaps there's a sanctioned way of adding a comment we're not using?), but this feels like a regression to me.
This doesn't happen in
0.7.2
.I'm assuming this is related to #12809
Examples:
The text was updated successfully, but these errors were encountered: