GitHub Actions output is missing file names and line numbers

[charliermarsh]

See: pypa/hatch#702 (comment).

Here's an example: https://github.com/pypa/hatch/actions/runs/3853184547/jobs/6565955257.

The action comments appear in the right spot in the "Files changed" tabs, but should the locations also be visible in the logs?

[ofek]

I think it should also be visible in the logs because the errors are from a newly released version of Ruff rather than any files I actually changed

[charliermarsh]

Are you suggesting that the line numbers and such were visible before, but are no longer visible?

[ofek]

Yes definitely but I don't remember how long ago

[charliermarsh]

Thanks, I'll look into it today.

[charliermarsh]

Relevant: golangci/golangci-lint-action#119

[charliermarsh]

I think this is "working as intended" from the perspective of GitHub's workflow commands.

Users can disable workflow commands (so they won't get inline comments, just build logs) with --format text or setting GITHUB_ACTIONS=false when invoking Ruff.

But the other thing we can do is add explicit additional text to the logs, even if it won't be picked up by GitHub, like:

[ofek]

Yes that would be nice! Do you know why in that example output the first error was showing the file and line numbers and the rest weren't? Was the first error just malformed and was accidentally being printed?

[charliermarsh]

I'm wondering that too. Not sure yet... Debugging it now.

[charliermarsh]

Two fixes here:

• The GitHub reporting is now opt-in (ruff --format=github .) instead of auto-detecting via the GITHUB_ACTIONS env var.
• When running with --format=github, we now preserve the location information:

[ofek]

Thanks!