Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove update-check support? #2515

Closed
charliermarsh opened this issue Feb 3, 2023 · 2 comments
Closed

Remove update-check support? #2515

charliermarsh opened this issue Feb 3, 2023 · 2 comments
Labels
question Asking for support or clarification

Comments

@charliermarsh
Copy link
Member

This used to be on-by-default, then we made it off-by-default. I can find a few usages of update-check = true via GitHub Code Search, but perhaps this isn't worth maintaining.
@charliermarsh charliermarsh added the question Asking for support or clarification label Feb 3, 2023
@JonathanPlasse
Copy link
Contributor

I do not think there is a need to keep it.
As every day there is a new release (which is greatly appreciated), you just know you can update.

@akx
Copy link
Contributor

akx commented Feb 3, 2023

👍 for getting rid of it.

akx added a commit to akx/ruff that referenced this issue Feb 3, 2023
@akx
Soft-deprecate update_check
f732266 
Setting update_check will only warn that it will be fully removed in a future version; a hard deprecation right now could cause havoc with people whose configuration sets it to true.

Refs astral-sh#2515
akx added a commit to akx/ruff that referenced this issue Feb 3, 2023
@akx
Soft-deprecate update_check
2fb1873 
Setting update_check will only warn that it will be fully removed in a future version; a hard deprecation right now could cause havoc with people whose configuration sets it to true.

Refs astral-sh#2515
@akx akx mentioned this issue Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Asking for support or clarification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akx @charliermarsh @JonathanPlasse