-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON schema should contain "NURSERY"
#7261
Comments
This may be addressed by #7195 |
Doesn't look like it to me: 6566d00#diff-0a03bc8f85db936902b6bfe61e0893160ee1c00de4253de91aa4fdb00202d73f doesn't seem to add |
I think these are manually excluded. The original intent was to hide them from autocompleting since we wanted to discourage ALL usage. But it ends up being too confusing that they’re marked as errors (we should fix). |
I think we'll want to exclude NURSERY since it's deprecated but include PREVIEW — I need to do a bit more work to decide if a PREVIEW selector makes sense though. |
In the case of nursery… I’m not sure — it seems wrong to mark a valid value as invalid. |
It's only valid as in "if you are using it currently we will not break your workflow on the next release" — I hope to remove it entirely soon. I could go either way on including it in the schema but would generally prefer to push people not to use it. Perhaps we can use a If someone wants to look into support for marking schema items as deprecated I'd be curious to review :) |
## Summary At some point, we removed these so that they wouldn't be autocompleted for users, since we wanted to discourage usage of `ALL`. But given that they're valid values, I think that was a bad idea -- it leads to an even more confusing experience whereby JSON Schema validators tell you that you have an error, when you don't. Closes #7261.
"NURSERY"
is missing hereruff/ruff.schema.json
Lines 1683 to 2754 in 9cb5ce7
leading to errors such as this:
The text was updated successfully, but these errors were encountered: