Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema should contain "NURSERY" #7261

Closed
bersbersbers opened this issue Sep 10, 2023 · 6 comments · Fixed by #7374
Closed

JSON schema should contain "NURSERY" #7261

bersbersbers opened this issue Sep 10, 2023 · 6 comments · Fixed by #7374
Assignees
Labels
bug Something isn't working

Comments

@bersbersbers
Copy link
Contributor

"NURSERY" is missing here

ruff/ruff.schema.json

Lines 1683 to 2754 in 9cb5ce7

"RuleSelector": {
"type": "string",
"enum": [
"A",
"A0",
"A00",
"A001",
"A002",
"A003",
"AIR",
"AIR0",
"AIR00",
"AIR001",
"ALL",
"ANN",
"ANN0",
"ANN00",
"ANN001",
"ANN002",
"ANN003",
"ANN1",
"ANN10",
"ANN101",
"ANN102",
"ANN2",
"ANN20",
"ANN201",
"ANN202",
"ANN204",
"ANN205",
"ANN206",
"ANN4",
"ANN40",
"ANN401",
"ARG",
"ARG0",
"ARG00",
"ARG001",
"ARG002",
"ARG003",
"ARG004",
"ARG005",
"ASYNC",
"ASYNC1",
"ASYNC10",
"ASYNC100",
"ASYNC101",
"ASYNC102",
"B",
"B0",
"B00",
"B002",
"B003",
"B004",
"B005",
"B006",
"B007",
"B008",
"B009",
"B01",
"B010",
"B011",
"B012",
"B013",
"B014",
"B015",
"B016",
"B017",
"B018",
"B019",
"B02",
"B020",
"B021",
"B022",
"B023",
"B024",
"B025",
"B026",
"B027",
"B028",
"B029",
"B03",
"B030",
"B031",
"B032",
"B033",
"B034",
"B9",
"B90",
"B904",
"B905",
"BLE",
"BLE0",
"BLE00",
"BLE001",
"C",
"C4",
"C40",
"C400",
"C401",
"C402",
"C403",
"C404",
"C405",
"C406",
"C408",
"C409",
"C41",
"C410",
"C411",
"C413",
"C414",
"C415",
"C416",
"C417",
"C418",
"C419",
"C9",
"C90",
"C901",
"COM",
"COM8",
"COM81",
"COM812",
"COM818",
"COM819",
"CPY",
"CPY001",
"D",
"D1",
"D10",
"D100",
"D101",
"D102",
"D103",
"D104",
"D105",
"D106",
"D107",
"D2",
"D20",
"D200",
"D201",
"D202",
"D203",
"D204",
"D205",
"D206",
"D207",
"D208",
"D209",
"D21",
"D210",
"D211",
"D212",
"D213",
"D214",
"D215",
"D3",
"D30",
"D300",
"D301",
"D4",
"D40",
"D400",
"D401",
"D402",
"D403",
"D404",
"D405",
"D406",
"D407",
"D408",
"D409",
"D41",
"D410",
"D411",
"D412",
"D413",
"D414",
"D415",
"D416",
"D417",
"D418",
"D419",
"DJ",
"DJ0",
"DJ00",
"DJ001",
"DJ003",
"DJ006",
"DJ007",
"DJ008",
"DJ01",
"DJ012",
"DJ013",
"DTZ",
"DTZ0",
"DTZ00",
"DTZ001",
"DTZ002",
"DTZ003",
"DTZ004",
"DTZ005",
"DTZ006",
"DTZ007",
"DTZ01",
"DTZ011",
"DTZ012",
"E",
"E1",
"E10",
"E101",
"E111",
"E112",
"E113",
"E114",
"E115",
"E116",
"E117",
"E201",
"E202",
"E203",
"E211",
"E221",
"E222",
"E223",
"E224",
"E225",
"E226",
"E227",
"E228",
"E231",
"E241",
"E242",
"E251",
"E252",
"E261",
"E262",
"E265",
"E266",
"E271",
"E272",
"E273",
"E274",
"E275",
"E4",
"E40",
"E401",
"E402",
"E5",
"E50",
"E501",
"E7",
"E70",
"E701",
"E702",
"E703",
"E71",
"E711",
"E712",
"E713",
"E714",
"E72",
"E721",
"E722",
"E73",
"E731",
"E74",
"E741",
"E742",
"E743",
"E9",
"E90",
"E902",
"E99",
"E999",
"EM",
"EM1",
"EM10",
"EM101",
"EM102",
"EM103",
"ERA",
"ERA0",
"ERA00",
"ERA001",
"EXE",
"EXE0",
"EXE00",
"EXE001",
"EXE002",
"EXE003",
"EXE004",
"EXE005",
"F",
"F4",
"F40",
"F401",
"F402",
"F403",
"F404",
"F405",
"F406",
"F407",
"F5",
"F50",
"F501",
"F502",
"F503",
"F504",
"F505",
"F506",
"F507",
"F508",
"F509",
"F52",
"F521",
"F522",
"F523",
"F524",
"F525",
"F54",
"F541",
"F6",
"F60",
"F601",
"F602",
"F62",
"F621",
"F622",
"F63",
"F631",
"F632",
"F633",
"F634",
"F7",
"F70",
"F701",
"F702",
"F704",
"F706",
"F707",
"F72",
"F722",
"F8",
"F81",
"F811",
"F82",
"F821",
"F822",
"F823",
"F84",
"F841",
"F842",
"F9",
"F90",
"F901",
"FA",
"FA1",
"FA10",
"FA100",
"FA102",
"FBT",
"FBT0",
"FBT00",
"FBT001",
"FBT002",
"FBT003",
"FIX",
"FIX0",
"FIX00",
"FIX001",
"FIX002",
"FIX003",
"FIX004",
"FLY",
"FLY0",
"FLY00",
"FLY002",
"FURB",
"FURB113",
"FURB131",
"FURB132",
"G",
"G0",
"G00",
"G001",
"G002",
"G003",
"G004",
"G01",
"G010",
"G1",
"G10",
"G101",
"G2",
"G20",
"G201",
"G202",
"I",
"I0",
"I00",
"I001",
"I002",
"ICN",
"ICN0",
"ICN00",
"ICN001",
"ICN002",
"ICN003",
"INP",
"INP0",
"INP00",
"INP001",
"INT",
"INT0",
"INT00",
"INT001",
"INT002",
"INT003",
"ISC",
"ISC0",
"ISC00",
"ISC001",
"ISC002",
"ISC003",
"N",
"N8",
"N80",
"N801",
"N802",
"N803",
"N804",
"N805",
"N806",
"N807",
"N81",
"N811",
"N812",
"N813",
"N814",
"N815",
"N816",
"N817",
"N818",
"N9",
"N99",
"N999",
"NPY",
"NPY0",
"NPY00",
"NPY001",
"NPY002",
"NPY003",
"PD",
"PD0",
"PD00",
"PD002",
"PD003",
"PD004",
"PD007",
"PD008",
"PD009",
"PD01",
"PD010",
"PD011",
"PD012",
"PD013",
"PD015",
"PD1",
"PD10",
"PD101",
"PD9",
"PD90",
"PD901",
"PERF",
"PERF1",
"PERF10",
"PERF101",
"PERF102",
"PERF2",
"PERF20",
"PERF203",
"PERF4",
"PERF40",
"PERF401",
"PERF402",
"PGH",
"PGH0",
"PGH00",
"PGH001",
"PGH002",
"PGH003",
"PGH004",
"PGH005",
"PIE",
"PIE7",
"PIE79",
"PIE790",
"PIE794",
"PIE796",
"PIE8",
"PIE80",
"PIE800",
"PIE804",
"PIE807",
"PIE808",
"PIE81",
"PIE810",
"PL",
"PLC",
"PLC0",
"PLC01",
"PLC010",
"PLC0105",
"PLC013",
"PLC0131",
"PLC0132",
"PLC02",
"PLC020",
"PLC0205",
"PLC0208",
"PLC04",
"PLC041",
"PLC0414",
"PLC1901",
"PLC3",
"PLC30",
"PLC300",
"PLC3002",
"PLE",
"PLE0",
"PLE01",
"PLE010",
"PLE0100",
"PLE0101",
"PLE011",
"PLE0116",
"PLE0117",
"PLE0118",
"PLE02",
"PLE024",
"PLE0241",
"PLE03",
"PLE030",
"PLE0302",
"PLE0307",
"PLE06",
"PLE060",
"PLE0604",
"PLE0605",
"PLE1",
"PLE11",
"PLE114",
"PLE1142",
"PLE12",
"PLE120",
"PLE1205",
"PLE1206",
"PLE13",
"PLE130",
"PLE1300",
"PLE1307",
"PLE131",
"PLE1310",
"PLE15",
"PLE150",
"PLE1507",
"PLE17",
"PLE170",
"PLE1700",
"PLE2",
"PLE25",
"PLE250",
"PLE2502",
"PLE251",
"PLE2510",
"PLE2512",
"PLE2513",
"PLE2514",
"PLE2515",
"PLR",
"PLR0",
"PLR01",
"PLR012",
"PLR0124",
"PLR013",
"PLR0133",
"PLR02",
"PLR020",
"PLR0206",
"PLR04",
"PLR040",
"PLR0402",
"PLR09",
"PLR091",
"PLR0911",
"PLR0912",
"PLR0913",
"PLR0915",
"PLR1",
"PLR17",
"PLR170",
"PLR1701",
"PLR171",
"PLR1711",
"PLR1714",
"PLR172",
"PLR1722",
"PLR2",
"PLR20",
"PLR200",
"PLR2004",
"PLR5",
"PLR55",
"PLR550",
"PLR5501",
"PLR6301",
"PLW",
"PLW0",
"PLW01",
"PLW012",
"PLW0120",
"PLW0127",
"PLW0129",
"PLW013",
"PLW0131",
"PLW04",
"PLW040",
"PLW0406",
"PLW06",
"PLW060",
"PLW0602",
"PLW0603",
"PLW07",
"PLW071",
"PLW0711",
"PLW1",
"PLW15",
"PLW150",
"PLW1508",
"PLW1509",
"PLW151",
"PLW1510",
"PLW1641",
"PLW2",
"PLW29",
"PLW290",
"PLW2901",
"PLW3",
"PLW3201",
"PLW33",
"PLW330",
"PLW3301",
"PT",
"PT0",
"PT00",
"PT001",
"PT002",
"PT003",
"PT004",
"PT005",
"PT006",
"PT007",
"PT008",
"PT009",
"PT01",
"PT010",
"PT011",
"PT012",
"PT013",
"PT014",
"PT015",
"PT016",
"PT017",
"PT018",
"PT019",
"PT02",
"PT020",
"PT021",
"PT022",
"PT023",
"PT024",
"PT025",
"PT026",
"PT027",
"PTH",
"PTH1",
"PTH10",
"PTH100",
"PTH101",
"PTH102",
"PTH103",
"PTH104",
"PTH105",
"PTH106",
"PTH107",
"PTH108",
"PTH109",
"PTH11",
"PTH110",
"PTH111",
"PTH112",
"PTH113",
"PTH114",
"PTH115",
"PTH116",
"PTH117",
"PTH118",
"PTH119",
"PTH12",
"PTH120",
"PTH121",
"PTH122",
"PTH123",
"PTH124",
"PTH2",
"PTH20",
"PTH201",
"PTH202",
"PTH203",
"PTH204",
"PTH205",
"PTH206",
"PTH207",
"PYI",
"PYI0",
"PYI00",
"PYI001",
"PYI002",
"PYI003",
"PYI004",
"PYI005",
"PYI006",
"PYI007",
"PYI008",
"PYI009",
"PYI01",
"PYI010",
"PYI011",
"PYI012",
"PYI013",
"PYI014",
"PYI015",
"PYI016",
"PYI017",
"PYI018",
"PYI019",
"PYI02",
"PYI020",
"PYI021",
"PYI024",
"PYI025",
"PYI026",
"PYI029",
"PYI03",
"PYI030",
"PYI032",
"PYI033",
"PYI034",
"PYI035",
"PYI036",
"PYI04",
"PYI041",
"PYI042",
"PYI043",
"PYI044",
"PYI045",
"PYI046",
"PYI047",
"PYI048",
"PYI049",
"PYI05",
"PYI050",
"PYI051",
"PYI052",
"PYI053",
"PYI054",
"PYI055",
"PYI056",
"Q",
"Q0",
"Q00",
"Q000",
"Q001",
"Q002",
"Q003",
"RET",
"RET5",
"RET50",
"RET501",
"RET502",
"RET503",
"RET504",
"RET505",
"RET506",
"RET507",
"RET508",
"RSE",
"RSE1",
"RSE10",
"RSE102",
"RUF",
"RUF0",
"RUF00",
"RUF001",
"RUF002",
"RUF003",
"RUF005",
"RUF006",
"RUF007",
"RUF008",
"RUF009",
"RUF01",
"RUF010",
"RUF011",
"RUF012",
"RUF013",
"RUF015",
"RUF016",
"RUF017",
"RUF1",
"RUF10",
"RUF100",
"RUF2",
"RUF20",
"RUF200",
"S",
"S1",
"S10",
"S101",
"S102",
"S103",
"S104",
"S105",
"S106",
"S107",
"S108",
"S11",
"S110",
"S112",
"S113",
"S3",
"S30",
"S301",
"S302",
"S303",
"S304",
"S305",
"S306",
"S307",
"S308",
"S31",
"S310",
"S311",
"S312",
"S313",
"S314",
"S315",
"S316",
"S317",
"S318",
"S319",
"S32",
"S320",
"S321",
"S323",
"S324",
"S5",
"S50",
"S501",
"S506",
"S508",
"S509",
"S6",
"S60",
"S601",
"S602",
"S603",
"S604",
"S605",
"S606",
"S607",
"S608",
"S609",
"S61",
"S612",
"S7",
"S70",
"S701",
"SIM",
"SIM1",
"SIM10",
"SIM101",
"SIM102",
"SIM103",
"SIM105",
"SIM107",
"SIM108",
"SIM109",
"SIM11",
"SIM110",
"SIM112",
"SIM114",
"SIM115",
"SIM116",
"SIM117",
"SIM118",
"SIM2",
"SIM20",
"SIM201",
"SIM202",
"SIM208",
"SIM21",
"SIM210",
"SIM211",
"SIM212",
"SIM22",
"SIM220",
"SIM221",
"SIM222",
"SIM223",
"SIM3",
"SIM30",
"SIM300",
"SIM4",
"SIM40",
"SIM401",
"SIM9",
"SIM91",
"SIM910",
"SLF",
"SLF0",
"SLF00",
"SLF001",
"SLOT",
"SLOT0",
"SLOT00",
"SLOT000",
"SLOT001",
"SLOT002",
"T",
"T1",
"T10",
"T100",
"T2",
"T20",
"T201",
"T203",
"TCH",
"TCH0",
"TCH00",
"TCH001",
"TCH002",
"TCH003",
"TCH004",
"TCH005",
"TD",
"TD0",
"TD00",
"TD001",
"TD002",
"TD003",
"TD004",
"TD005",
"TD006",
"TD007",
"TID",
"TID2",
"TID25",
"TID251",
"TID252",
"TID253",
"TRY",
"TRY0",
"TRY00",
"TRY002",
"TRY003",
"TRY004",
"TRY2",
"TRY20",
"TRY200",
"TRY201",
"TRY3",
"TRY30",
"TRY300",
"TRY301",
"TRY302",
"TRY4",
"TRY40",
"TRY400",
"TRY401",
"UP",
"UP0",
"UP00",
"UP001",
"UP003",
"UP004",
"UP005",
"UP006",
"UP007",
"UP008",
"UP009",
"UP01",
"UP010",
"UP011",
"UP012",
"UP013",
"UP014",
"UP015",
"UP017",
"UP018",
"UP019",
"UP02",
"UP020",
"UP021",
"UP022",
"UP023",
"UP024",
"UP025",
"UP026",
"UP027",
"UP028",
"UP029",
"UP03",
"UP030",
"UP031",
"UP032",
"UP033",
"UP034",
"UP035",
"UP036",
"UP037",
"UP038",
"UP039",
"UP04",
"UP040",
"W",
"W1",
"W19",
"W191",
"W2",
"W29",
"W291",
"W292",
"W293",
"W5",
"W50",
"W505",
"W6",
"W60",
"W605",
"YTT",
"YTT1",
"YTT10",
"YTT101",
"YTT102",
"YTT103",
"YTT2",
"YTT20",
"YTT201",
"YTT202",
"YTT203",
"YTT204",
"YTT3",
"YTT30",
"YTT301",
"YTT302",
"YTT303"
]
},

leading to errors such as this:

image

@zanieb
Copy link
Member

zanieb commented Sep 10, 2023

This may be addressed by #7195

@bersbersbers
Copy link
Contributor Author

This may be addressed by #7195

Doesn't look like it to me: 6566d00#diff-0a03bc8f85db936902b6bfe61e0893160ee1c00de4253de91aa4fdb00202d73f doesn't seem to add "NURSERY" nor "PREVIEW".

@charliermarsh
Copy link
Member

I think these are manually excluded. The original intent was to hide them from autocompleting since we wanted to discourage ALL usage. But it ends up being too confusing that they’re marked as errors (we should fix).

@zanieb
Copy link
Member

zanieb commented Sep 11, 2023

I think we'll want to exclude NURSERY since it's deprecated but include PREVIEW — I need to do a bit more work to decide if a PREVIEW selector makes sense though.

@charliermarsh
Copy link
Member

In the case of nursery… I’m not sure — it seems wrong to mark a valid value as invalid.

@zanieb
Copy link
Member

zanieb commented Sep 11, 2023

It's only valid as in "if you are using it currently we will not break your workflow on the next release" — I hope to remove it entirely soon. I could go either way on including it in the schema but would generally prefer to push people not to use it. Perhaps we can use a deprecated keyword per json-schema-org/json-schema-spec#737

If someone wants to look into support for marking schema items as deprecated I'd be curious to review :)

@charliermarsh charliermarsh self-assigned this Sep 14, 2023
@charliermarsh charliermarsh added the bug Something isn't working label Sep 14, 2023
charliermarsh added a commit that referenced this issue Sep 14, 2023
## Summary

At some point, we removed these so that they wouldn't be autocompleted
for users, since we wanted to discourage usage of `ALL`. But given that
they're valid values, I think that was a bad idea -- it leads to an even
more confusing experience whereby JSON Schema validators tell you that
you have an error, when you don't.

Closes #7261.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants