Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid-escape-sequence (W605) quick fix has incorrect description #8155

Closed
DetachHead opened this issue Oct 24, 2023 · 0 comments · Fixed by #8255
Closed

invalid-escape-sequence (W605) quick fix has incorrect description #8155

DetachHead opened this issue Oct 24, 2023 · 0 comments · Fixed by #8255
Assignees
@dhruvmanila
Labels
bug Something isn't working

Comments

@DetachHead
Copy link

the quick fix says "Add backslash to escape sequence":
image

but it actually turns it into a r string instead:

r"\d"

https://play.ruff.rs/0aa99ac0-9dff-4f90-affb-36f66b885661
@dhruvmanila dhruvmanila added the bug Something isn't working label Oct 24, 2023
@dhruvmanila dhruvmanila self-assigned this Oct 24, 2023
@dhruvmanila dhruvmanila mentioned this issue Oct 24, 2023
Merged
zanieb pushed a commit that referenced this issue Oct 26, 2023
@dhruvmanila
Correct quick fix message for W605 (#8156)
a7c0258 
## Summary

This PR fixes the `W605` rule implementation to provide the quickfix
message as
per the fix provided.

## Test Plan

Update snapshots.

fixes: #8155
@dhruvmanila dhruvmanila mentioned this issue Oct 26, 2023
Merged
dhruvmanila added a commit that referenced this issue Oct 26, 2023
@dhruvmanila
Correct quick fix message for W605 (#8255)
4ffd4ed 
## Summary

This PR fixes the `W605` rule implementation to provide the quickfix
message as
per the fix provided.

## Test Plan

Update snapshots.

fixes: #8155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct quick fix message for W605 astral-sh/ruff
2 participants
@DetachHead @dhruvmanila