Mark quotes as unnecessary for non-evaluated annotations #11485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/runtime-annotations
branch
from
877ad56 to
2876c33
Compare
rdimaio
added a commit
to rdimaio/rucio
that referenced
this pull request
May 24, 2024
Ruff 0.4.5 changes the logic used to detect UP037, mainly via this PR: astral-sh/ruff#11485. I am seeing some possible false positive due to this, e.g.: > Error: lib/rucio/core/authentication.py:571:27: UP037 Remove quotes from type annotation where it asks to remove quotes from a type that's only imported in a type-checking block. This is a very new Ruff version so it's best to check back at a later point to see if this is a common issue for other repositories too.
bari12
pushed a commit
to rucio/rucio
that referenced
this pull request
May 24, 2024
Ruff 0.4.5 changes the logic used to detect UP037, mainly via this PR: astral-sh/ruff#11485. I am seeing some possible false positive due to this, e.g.: > Error: lib/rucio/core/authentication.py:571:27: UP037 Remove quotes from type annotation where it asks to remove quotes from a type that's only imported in a type-checking block. This is a very new Ruff version so it's best to check back at a later point to see if this is a common issue for other repositories too.
bari12
pushed a commit
to rucio/rucio
that referenced
this pull request
May 24, 2024
Ruff 0.4.5 changes the logic used to detect UP037, mainly via this PR: astral-sh/ruff#11485. I am seeing some possible false positive due to this, e.g.: > Error: lib/rucio/core/authentication.py:571:27: UP037 Remove quotes from type annotation where it asks to remove quotes from a type that's only imported in a type-checking block. This is a very new Ruff version so it's best to check back at a later point to see if this is a common issue for other repositories too.
labkode
pushed a commit
to labkode/rucio
that referenced
this pull request
Jun 26, 2024
Ruff 0.4.5 changes the logic used to detect UP037, mainly via this PR: astral-sh/ruff#11485. I am seeing some possible false positive due to this, e.g.: > Error: lib/rucio/core/authentication.py:571:27: UP037 Remove quotes from type annotation where it asks to remove quotes from a type that's only imported in a type-checking block. This is a very new Ruff version so it's best to check back at a later point to see if this is a common issue for other repositories too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #11414, this PR extends
UP037to flag quoted annotations that are located in positions that won't be evaluated at runtime.For example, the quotes on
Tupleare unnecessary in: