Move has_comments to CommentRanges
#11495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
May 22, 2024
|
MichaReiser
reviewed
May 27, 2024
| @@ -384,7 +384,11 @@ pub(crate) fn unittest_raises_assertion( | |||
| }, | |||
| call.func.range(), | |||
| ); | |||
| if !checker.indexer().has_comments(call, checker.locator()) { | |||
| if !checker | |||
There was a problem hiding this comment.
Nit: You could have kept the has_comments method on Indexer and simply forwarded the call to CommentRanges to reduce the diff size (It also increases encapsulation because callers don't need to know how the Indexer represents the data internally)
There was a problem hiding this comment.
I'm not sure if that makes any difference in terms of encapsulation because CommentRanges is already exposed via indexer.comment_ranges and calls to the other methods on CommentRanges are done directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the
has_commentsfunction fromIndexertoCommentRanges. The main motivation is that theCommentRangeswill now be built by the parser which is shared between the linter and the formatter. Thus, theCommentRangeswill be removed from theIndexer.Test Plan
cargo test