-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand note to use Ruff with other language server in Kate #12806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
I'm a bit hesitant on including this section with all the details as provided here. We had a section for python-lsp-ruff
before the stable release of the Ruff language server (https://github.com/astral-sh/ruff/blob/7a7c601d5ed294a3c868b5e83f757105e0a189b8/docs/integrations.md#language-server-protocol-unofficial) but we removed it in favor of promoting the native language server. Another important difference with python-lsp-ruff
is that it uses the ruff
executable which means that the server settings won't be considered if provided.
That said, what we could do is to expand on the important
note section stating that if someone would like to use Ruff along with another language server, the python-lsp
can be used as a language server along with the python-lsp-ruff
plugin. We should also state that the Ruff plugin used here would be through the executable. You might want to paraphrase this.
What do you think about this?
Hi @dhruvmanila could you elaborate on the settings part? Otherwise, just let me tell you why I did it that way:
That being said, I understand if you do not want to risk that burden, or having people asking about how to use pylsp-ruff in your issue tracker. |
I mean the server settings as mentioned here: https://docs.astral.sh/ruff/editors/settings. Some of them controls the behavior of the server itself ( I think your reasoning makes sense but I'd rather prefer to re-use existing resources from other documentations. There have been some confusion in the past with how the server settings are suppose to work like #12778 and #12514 where the users were confused that the server settings weren't being considered when running the linter / formatter. I think having a general guide on how to setup the That said, I think it would be more useful to expand the note by informing the users that they could use |
OK, I think this should probably be mentioned in the note, then.
As I mentioned, I don't think people know much about these tools and would expect them to have heard (like me) that ruff is super fast and so they would want to use it and would just arrive on the ruff docs without prior knowledge. However, I completely understand your reasoning and definitely agree that it would be better to have the detailed doc where it belongs (somewhere in the pylsp ecosystem) and just link to it in the ruff documentation.
I'll propose something along those lines, then, and maybe I'll make another PR once I have added the detailed configuration somewhere in the pylsp documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded the "important" note for the Kate setup guide with a workaround for using Ruff with another language server. Feel free to provide any thoughts on that. I'll merge this for now but happy to take any follow-ups if you have any in mind. Thanks for the suggestion and opening this PR.
OK, that seems reasonable! I'll try to propose something to python-lsp people, thanks! |
Summary
Provide instructions to use Ruff together with other servers in the Kate editor.
Because Kate does not support running multiple servers for the same language, one needs to use the
python-lsp-server
(pylsp) tool.