[Ruff 0.6] Stabilise 9 pylint rules #12857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLW0642 | 52 | 52 | 0 | 0 | 0 |
| PLR1730 | 13 | 13 | 0 | 0 | 0 |
| PLW0211 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+52 -52 violations, +0 -0 fixes in 2 projects; 52 projects unchanged)
bokeh/bokeh (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ src/bokeh/events.py:182:9: PLW0642 Confusing assignment to `cls` argument in class method - src/bokeh/events.py:182:9: PLW0642 Invalid assignment to `cls` argument in class method
pandas-dev/pandas (+51 -51 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ pandas/core/arrays/categorical.py:572:13: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/categorical.py:572:13: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1065:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1065:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1080:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1080:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1081:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1081:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1109:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1109:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1118:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1118:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1129:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1129:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1131:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1131:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1136:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1136:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1185:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1185:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1187:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1187:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1203:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1203:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1260:13: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1260:13: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1274:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1274:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1480:13: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1480:13: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:1699:13: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:1699:13: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:2131:17: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:2131:17: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:2153:13: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:2153:13: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:456:17: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:456:17: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:778:13: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:778:13: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/arrays/datetimelike.py:979:13: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/arrays/datetimelike.py:979:13: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/frame.py:7827:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/frame.py:7827:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/frame.py:7840:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/frame.py:7840:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/frame.py:8183:9: PLW0642 Confusing assignment to `self` argument in instance method - pandas/core/frame.py:8183:9: PLW0642 Invalid assignment to `self` argument in instance method + pandas/core/frame.py:8195:21: PLW0642 Confusing assignment to `self` argument in instance method ... 53 additional changes omitted for project
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLW0642 | 104 | 52 | 52 | 0 | 0 |
|
The vast majority of the ecosystem hit here are PLR6104. I'll split that one out into its own PR so that it can be considered in isolation. (Edit: this has now been done; the PR for that is #12858) |
AlexWaygood
force-pushed
the
pylint-stabilisations
branch
from
b54bc7c to
e0bd79c
Compare
AlexWaygood
changed the title
|
There's a lot of |
|
LGTM. My only feedback for |
MichaReiser
approved these changes
Aug 13, 2024
Yeah, that's a great point. I think I'll change it to "confusing". It's not an invalid assignment; you could just write the code in a clearer/less confusing way by using a different variable name. |
dhruvmanila
reviewed
Aug 13, 2024
Comment on lines
+60
to
+63
|
|
||
| fn fix_title(&self) -> Option<String> { | ||
| Some("Consider using a different variable name".to_string()) | ||
| } |
Comment on lines
55
to
57
| format!( | ||
| "Invalid assignment to `{}` argument in {method_type} method", | ||
| "Confusing assignment to `{}` argument in {method_type} method", | ||
| method_type.arg_name(), |
There was a problem hiding this comment.
Another option could be "Re-assigned {} argument in {method_type} method"
There was a problem hiding this comment.
Oh, that's better. Much more descriptive. I'll make another PR 😄
Merged
AlexWaygood
added a commit
that referenced
this pull request
Aug 14, 2024
MichaReiser
pushed a commit
that referenced
this pull request
Aug 14, 2024
MichaReiser
pushed a commit
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stabilise the following rules for Ruff 0.6:
singledispatch-method(PLE1519)singledispatchmethod-function(PLE1520)bad-staticmethod-argument(PLW0211)if-stmt-min-max(PLR1730)invalid-bytes-return-type(PLE0308)invalid-hash-return-type(PLE0309)invalid-index-return-type(PLE0305)invalid-length-return-type(E303)non-augmented-assignment(PLR6104)self-or-cls-assignment(PLW0642)These rules all seem fairly uncontroversial, they've all been in preview for >3 months (and haven't changed much in a while), and none of them have any significant issues open about them that should block stabilisation IMO.
Test Plan
cargo test, but the ecoystem report will be the real judge...