Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] add initial Type::is_equivalent_to and Type::is_assignable_to #13332

Merged
merged 4 commits into from
Sep 12, 2024
Merged

[red-knot] add initial Type::is_equivalent_to and Type::is_assignable_to #13332

merged 4 commits into from
Sep 12, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Sep 12, 2024

These are quite incomplete, but I needed to start stubbing them out in order to build and test declared-types.

Allowing unused for now, until they are used later in the declared-types PR.

@carljm carljm added the red-knot Multi-file analysis & type inference label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@carljm carljm marked this pull request as ready for review September 12, 2024 02:44
AlexWaygood
AlexWaygood approved these changes Sep 12, 2024
View reviewed changes
crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved
crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
MichaReiser
MichaReiser approved these changes Sep 12, 2024
View reviewed changes
crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved
@carljm carljm merged commit 175d067 into main Sep 12, 2024
20 checks passed
@carljm carljm deleted the cjm/assignable branch September 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carljm @MichaReiser @AlexWaygood