Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] add BitSet::is_empty and BitSet::union #13333

Merged
merged 6 commits into from
Sep 12, 2024
Merged

[red-knot] add BitSet::is_empty and BitSet::union #13333

merged 6 commits into from
Sep 12, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Sep 12, 2024

Add ::is_empty and ::union methods to the BitSet implementation.

Allowing unused for now, until these methods become used later with the declared-types implementation.

@carljm carljm added the red-knot Multi-file analysis & type inference label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@carljm carljm marked this pull request as ready for review September 12, 2024 03:05
Base automatically changed from cjm/assignable to main September 12, 2024 18:15
@carljm carljm merged commit 43a5922 into main Sep 12, 2024
20 checks passed
@carljm carljm deleted the cjm/bitset branch September 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carljm @MichaReiser @AlexWaygood