[ruff] Unformatted special comments (RUF037)

crates/ruff_linter/resources/test/fixtures/ruff/RUF104.py

@@ -0,0 +1,92 @@
+#foo
+# foo
+#ruff: foo-bar
+# flake8:foo-bar
+#  black:skip
+
+# FMT:OFF
+# isort: On
+# Mypy: disallow-subclassing-any
+# PyRight: basic
+# Type: ignore
+
+# noqa
+# noqa: A123
+# noqa: A123, B456
+# ruff: noqa
+# ruff: noqa: A123
+# ruff: noqa: A123, B456
+# flake8: noqa
+# flake8: noqa: A123
+# flake8: noqa: A123, B456
+# fmt: on
+# fmt: off
+# fmt: skip
+# isort: on
+# isort: off
+# isort: split
+# isort: skip
+# isort: skip_file
+# mypy: enable-error-codes=
+# nopycln: file
+# nopycln: import
+# pyright: basic
+# pyright: standard
+# pyright: strict
+# pyright: ignore
+# pyright: ignore [reportFoo]
+# ruff: isort: on
+# ruff: isort: skip_file
+# type: ignore
+# type: int
+# type: list[str]
+
+# noqa:A123
+#noqa:   A123
+#    type:ignore
+#type:	int
+# fmt:off
+#fmt: on
+# 	 fmt:	 skip
+# isort:skip
+# isort:skip_file
+# mypy:  disallow-subclassing-any
+#   nopycln: 	 		file
+# 	nopycln:	   import
+#pyright:ignore[]
+#			pyright:    ignore[]
+# ruff: isort:skip
+# ruff: isort:skip_file
+#    type:			ignore
+#	 	 	type:		 	int
+
+# NoQA: A123, B456
+# ruff: NoQA: A123, B456
+# flake8: NoQA: A123, B456
+# NoPyCLN: File
+# NoPycln: Import
+# nOpYcLn: iMpOrT
+
+# noqa: A123 B456
+# ruff: noqa: A123 B456
+# flake8: noqa: A123 B456
+# noqa: A123,B456
+# ruff: noqa: A123,B456
+# flake8: noqa: A123,B456
+# noqa: A123,,B456
+# noqa: A123 , 	,	 	B456
+# noqa: A123	B456
+# noqa: A123			B456
+# noqa: A123				B456
+# noqa: A123 ,B456
+# ruff: noqa: A123	B456
+# flake8: noqa: A123   B456
+
+
+# type: ignore  # noqa: A123, B456
+
+#pyright:ignore#noqa:A123
+
+# nopycln:file#   noqa: A123
+
+# noqa:A123 - Lorem ipsum dolor sit amet

crates/ruff_linter/resources/test/fixtures/ruff/RUF104_1.py

@@ -0,0 +1,8 @@
+###
+# Both of these should trigger RUF104
+# as it is not explicitly suppressed.
+###
+
+# ruff:noqa
+
+#noqa:A123

crates/ruff_linter/resources/test/fixtures/ruff/RUF104_2.py

@@ -0,0 +1,8 @@
+###
+# None of these should trigger RUF104
+# as it is explicitly suppressed for the entire file.
+###
+
+# flake8:noqa:RUF104
+
+#noqa:A123

crates/ruff_linter/resources/test/fixtures/ruff/RUF104_3.py

@@ -0,0 +1,7 @@
+###
+# All of these should be reformatted.
+###
+
+#noqa:
+#ruff:noqa:
+#flake8:noqa:

crates/ruff_linter/src/checkers/noqa.rs

@@ -51,8 +51,15 @@ pub(crate) fn check_noqa(
 
         match &exemption {
             FileExemption::All(_) => {
-                // If the file is exempted, ignore all diagnostics.
-                ignored_diagnostics.push(index);
+                // If the file is exempted, ignore all diagnostics,
+                // save for RUF104, which operates on `# noqa` comments
+                // and thus needs to be suppressed explicitly.
+                if !matches!(diagnostic.kind.rule(), Rule::UnformattedSpecialComment)
+                    || per_file_ignores.contains(Rule::UnformattedSpecialComment)
+                    || exemption.enumerates(Rule::UnformattedSpecialComment)
+                {
+                    ignored_diagnostics.push(index);
+                }
                 continue;
             }
             FileExemption::Codes(codes) => {

crates/ruff_linter/src/checkers/tokens.rs

@@ -191,6 +191,10 @@ pub(crate) fn check_tokens(
         pycodestyle::rules::too_many_newlines_at_end_of_file(&mut diagnostics, tokens);
     }
 
+    if settings.rules.enabled(Rule::UnformattedSpecialComment) {
+        ruff::rules::unformatted_special_comment(&mut diagnostics, locator, comment_ranges);
+    }
+
     diagnostics.retain(|diagnostic| settings.rules.enabled(diagnostic.kind.rule()));
 
     diagnostics

crates/ruff_linter/src/codes.rs

@@ -967,6 +967,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Ruff, "034") => (RuleGroup::Preview, rules::ruff::rules::UselessIfElse),
         (Ruff, "100") => (RuleGroup::Stable, rules::ruff::rules::UnusedNOQA),
         (Ruff, "101") => (RuleGroup::Stable, rules::ruff::rules::RedirectedNOQA),
+        (Ruff, "104") => (RuleGroup::Preview, rules::ruff::rules::UnformattedSpecialComment),
 
         (Ruff, "200") => (RuleGroup::Stable, rules::ruff::rules::InvalidPyprojectToml),
         #[cfg(any(feature = "test-rules", test))]

crates/ruff_linter/src/registry.rs

@@ -301,6 +301,7 @@ impl Rule {
             | Rule::TrailingCommaOnBareTuple
             | Rule::TypeCommentInStub
             | Rule::UselessSemicolon
+            | Rule::UnformattedSpecialComment
             | Rule::UTF8EncodingDeclaration => LintSource::Tokens,
             Rule::IOError => LintSource::Io,
             Rule::UnsortedImports | Rule::MissingRequiredImport => LintSource::Imports,

crates/ruff_linter/src/rules/fastapi/rules/fastapi_redundant_response_model.rs

@@ -73,7 +73,7 @@ impl AlwaysFixableViolation for FastApiRedundantResponseModel {
     }
 }
 
-/// RUF102
+/// FAST001
 pub(crate) fn fastapi_redundant_response_model(
     checker: &mut Checker,
     function_def: &StmtFunctionDef,

crates/ruff_linter/src/rules/ruff/mod.rs

@@ -58,9 +58,9 @@ mod tests {
     #[test_case(Rule::AssertWithPrintMessage, Path::new("RUF030.py"))]
     #[test_case(Rule::IncorrectlyParenthesizedTupleInSubscript, Path::new("RUF031.py"))]
     #[test_case(Rule::DecimalFromFloatLiteral, Path::new("RUF032.py"))]
+    #[test_case(Rule::PostInitDefault, Path::new("RUF033.py"))]
     #[test_case(Rule::UselessIfElse, Path::new("RUF034.py"))]
     #[test_case(Rule::RedirectedNOQA, Path::new("RUF101.py"))]
-    #[test_case(Rule::PostInitDefault, Path::new("RUF033.py"))]
     fn rules(rule_code: Rule, path: &Path) -> Result<()> {
         let snapshot = format!("{}_{}", rule_code.noqa_code(), path.to_string_lossy());
         let diagnostics = test_path(
@@ -384,6 +384,10 @@ mod tests {
     }
 
     #[test_case(Rule::ZipInsteadOfPairwise, Path::new("RUF007.py"))]
+    #[test_case(Rule::UnformattedSpecialComment, Path::new("RUF104.py"))]
+    #[test_case(Rule::UnformattedSpecialComment, Path::new("RUF104_1.py"))]
+    #[test_case(Rule::UnformattedSpecialComment, Path::new("RUF104_2.py"))]
+    #[test_case(Rule::UnformattedSpecialComment, Path::new("RUF104_3.py"))]
     fn preview_rules(rule_code: Rule, path: &Path) -> Result<()> {
         let snapshot = format!(
             "preview__{}_{}",

crates/ruff_linter/src/rules/ruff/rules/mod.rs

@@ -26,6 +26,7 @@ pub(crate) use sort_dunder_slots::*;
 pub(crate) use static_key_dict_comprehension::*;
 #[cfg(any(feature = "test-rules", test))]
 pub(crate) use test_rules::*;
+pub(crate) use unformatted_special_comment::*;
 pub(crate) use unnecessary_iterable_allocation_for_first_element::*;
 pub(crate) use unnecessary_key_check::*;
 pub(crate) use unused_async::*;
@@ -65,6 +66,7 @@ mod static_key_dict_comprehension;
 mod suppression_comment_visitor;
 #[cfg(any(feature = "test-rules", test))]
 pub(crate) mod test_rules;
+mod unformatted_special_comment;
 mod unnecessary_iterable_allocation_for_first_element;
 mod unnecessary_key_check;
 mod unused_async;