-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruff
] Do not report when Optional
has no type arguments (RUF013
)
#14181
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this issue.
The check looks good to me, but I think we should move it into type_hint_explicitly_allows_none
so that Annotated[Optional, "bla"]
also works
I'm confused, bare |
That’s correct but seems outside the scope of the rule? Like a bare Optional being invalid should be its own rule. |
Ah, yes, that makes sense. |
Summary
Resolves #13833.
Test Plan
cargo nextest run
andcargo insta test
.