[red-knot] Make attributes.md test future-proof
#14923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `typing.Literal` breaks as soon as we understand `sys.version_info` branches, as it's only available in 3.11 and later.
sharkdp
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
|
Oh, you mean |
AlexWaygood
approved these changes
Dec 11, 2024
Yes, thanks!
No worries — I just wanted to pull it out from #14759 which seems big enough already. And I wasn't sure if you'd be okay with the change here. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using
typing.LiteralStringbreaks as soon as we understandsys.version_infobranches, as it's only available in 3.11 and later.Test Plan
Made sure it didn't fail on my #14759 branch anymore.