Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint]: Stabilize boolean-chained-comparison (PLR1716) #15354

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jan 8, 2025

Summary

Stabilizes boolean-chained-comparison.

Test Plan

There are no open issues or PRs related to this rule.

The last bug fix was implemented about a month ago.

@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Jan 8, 2025
@MichaReiser MichaReiser added this to the v0.9 milestone Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)

pytest-dev/pytest (+1 -0 violations, +0 -0 fixes)

+ testing/_py/test_local.py:21:12: PYI006 Use `<` or `>=` for `sys.version_info` comparisons

astropy/astropy (+1 -0 violations, +0 -0 fixes)

+ astropy/cosmology/flrw/lambdacdm.py:267:15: PLR1716 [*] Contains chained boolean comparison that can be simplified

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
PYI006 1 1 0 0 0
PLR1716 1 1 0 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)

apache/airflow (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- airflow/decorators/condition.py:32:35: TC008 [*] Remove quotes from type alias
- airflow/decorators/condition.py:33:35: TC008 [*] Remove quotes from type alias

latchbio/latch (+0 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

- src/latch/ldata/_transfer/upload.py:30:32: TC008 [*] Remove quotes from type alias
- src/latch/ldata/_transfer/upload.py:31:35: TC008 [*] Remove quotes from type alias

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
TC008 4 0 4 0 0

@MichaReiser MichaReiser marked this pull request as ready for review January 8, 2025 14:11
@MichaReiser MichaReiser merged commit 890f290 into ruff-0.9 Jan 8, 2025
21 checks passed
@MichaReiser MichaReiser deleted the micha/boolean-chain-comparison branch January 8, 2025 14:43
@MichaReiser MichaReiser mentioned this pull request Jan 8, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants