Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust toolchain to 1.84.0 #15408

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Upgrade Rust toolchain to 1.84.0 #15408

merged 2 commits into from
Jan 11, 2025

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jan 10, 2025

Summary

Upgrade the rust toolchain to 1.84.0. This PR does not bump the MSRV.

Test Plan

cargo test

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Jan 10, 2025
Comment on lines +214 to +215
# Diagnostics are not actionable: Enable once https://github.com/rust-lang/rust-clippy/issues/13774 is resolved.
large_stack_arrays = "allow"
Copy link
Member Author

@MichaReiser MichaReiser Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    Checking ruff v0.9.1 (/Users/micha/astral/ruff/crates/ruff)
warning: allocating a local array larger than 16384 bytes
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays
  = note: `-W clippy::large-stack-arrays` implied by `-W clippy::pedantic`
  = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_stack_arrays)]`

warning: `ruff_linter` (lib test) generated 1 warning

but ruff_linter is kind of big.

I subscribed to the issue

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

warning: Detected debug build without --no-cache.
error: Failed to read examples/Assistants_API_overview_python.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: expected `,` or `]` at line 197 column 8

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/Assistants_API_overview_python.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: expected `,` or `]` at line 197 column 8

@MichaReiser MichaReiser merged commit c39ca8f into main Jan 11, 2025
21 checks passed
@MichaReiser MichaReiser deleted the rust-184 branch January 11, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants