Supplement isort options #3266
Supplement isort options #3266
Conversation
| pub reverse_relative: bool, | ||
| #[serde(default)] | ||
| pub force_single_line: bool, | ||
| #[serde(default)] |
There was a problem hiding this comment.
These may all need the alias = "single-line-exclusions", alias = "single_line_exclusions" treatment as seen in src_paths, to respect isort's acceptance of either casing style.
There was a problem hiding this comment.
I added such aliases too! Thanks! 🙏🏻
|
Seems like a reasonable start! I might suggest only implementing those options that we support within Ruff for now, to make things easier. see: https://beta.ruff.rs/docs/settings/#isort. |
moreal
force-pushed
the
isort-options
branch
4 times, most recently
from
ddb2d61 to
14b2eb3
Compare
Thank you for your suggestion. I added more options from https://beta.ruff.rs/docs/settings/#isort and clean up other options, not in the document. 🙏🏻 |
|
I'm going to close this for now, just to keep the open PR list tight. If you choose to return to this, we can always reopen! |
This pull request is related to the #1749 issue but it doesn't resolve the problem perfectly yet. I opened this pull request to check the intermediate stage with reviewing.
I referenced https://github.com/PyCQA/isort/blob/3a72e069635a865a92b8a0273aa829f630cbcd6f/isort/settings.py source file.