Ability to perform integration test on Jupyter notebooks #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
dhruvmanila
commented
Jun 14, 2023
crates/ruff/src/jupyter/snapshots/ruff__jupyter__notebook__test__import_sorting.snap
Outdated
Show resolved
Hide resolved
dhruvmanila
commented
Jun 14, 2023
crates/ruff/src/test.rs
Outdated
Comment on lines
66
to
71
| if let SourceKind::Jupyter(notebook) = source_kind { | ||
| assert_eq!(notebook.cell_offsets(), expected_notebook.cell_offsets()); | ||
| assert_eq!(notebook.index(), expected_notebook.index()); | ||
| assert_eq!(notebook.content(), expected_notebook.content()); | ||
| }; | ||
| Ok(messages) |
There was a problem hiding this comment.
Should we use snapshots as we'll be asserting the content here itself?
There was a problem hiding this comment.
You could move the assert_messages!(diagnostics); here but it's fine either way
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
konstin
approved these changes
Jun 14, 2023
crates/ruff/src/test.rs
Outdated
Comment on lines
66
to
71
| if let SourceKind::Jupyter(notebook) = source_kind { | ||
| assert_eq!(notebook.cell_offsets(), expected_notebook.cell_offsets()); | ||
| assert_eq!(notebook.index(), expected_notebook.index()); | ||
| assert_eq!(notebook.content(), expected_notebook.content()); | ||
| }; | ||
| Ok(messages) |
There was a problem hiding this comment.
You could move the assert_messages!(diagnostics); here but it's fine either way
dhruvmanila
commented
Jun 14, 2023
| } | ||
| } | ||
|
|
||
| pub(crate) fn print_jupyter_messages( |
There was a problem hiding this comment.
This seems a bit hacky to print cell information in the snapshot but just thought to put it out there to gain some feedback. The diff lines are also incorrect which should be fixed once the support is added.
We could just avoid creating snapshots and test out using assert_eq! which is already being done for cell_offsets, index and content.
For reference, this is the commit which is isolated to this change (f63103b)
There was a problem hiding this comment.
I trust @konstin on this one, not gonna review closely ;)
|
I'll add some more tests now that we've the ability to do so! |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ability to perform integration test on Jupyter notebooks
Part of #1218
Test Plan
cargo test